-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: migrate to Poetry & pyproject.toml #1387
Conversation
9c3c892
to
7a041d7
Compare
cc @xwings please review :) |
code looks good to me. one more approve we are good to go |
Any ideas on the eth_abi v4 thing? I literally have zero experience with Ethereum, updating to the new |
@nullableVoidPtr Hi, do you have time to take a look at this, since you authored #1111? |
Looks good overall, but separating linting in a single commit would be fine. Anyway nice work! This PR reminds me one thing, maybe we should really mention we only deal with |
Just one more thing, could you test if the release CI breaks or not? |
I tested it on my local machine with a dry run, no issue so far. |
CI seems to be good. @wtdcode you might need to approve the code |
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
Migrate the project to Poetry.
Supersedes #1111.