Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve a IDAPython relocation issue #1485

Merged

Conversation

co-neco
Copy link

@co-neco co-neco commented Jul 15, 2024

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • [] This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@co-neco
Copy link
Author

co-neco commented Jul 15, 2024

In Arm64 environment, default so module base address is 0x555555554000, not 0. So qilingida.py->ql_set_pc would convert ida address to qiling address(see ql_addr_from_ida method).

@kabeor
Copy link
Member

kabeor commented Aug 9, 2024

Thank you, Merged.

@kabeor kabeor merged commit ea1a17b into qilingframework:dev Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants