Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins disable #1219

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add plugins disable #1219

merged 1 commit into from
Nov 26, 2024

Conversation

marschattha
Copy link
Member

@marschattha marschattha commented Nov 26, 2024

Add plugins disable subcommand

@marschattha marschattha requested a review from brynary November 26, 2024 13:47
Copy link
Contributor

qltysh bot commented Nov 26, 2024

❌ 1 blocking issue (1 total)

Tool Category Rule Count
qlty Duplication Found 41 lines of similar code in 2 locations (mass = 155) 1

qlty successfully analyzed this pull request in 1m.

Copy link
Contributor

qltysh bot commented Nov 26, 2024

The code coverage on the diff in this pull request is 79.0%

Drilldown
Path File Coverage Δ
qlty-check/src/tool/command_builder.rs 2.6
qlty-cli/src/initializer/scanner/gemfile.rs -0.3
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-check/src/tool/download.rs 0.7
qlty-config/src/workspace.rs 2.6
qlty-check/src/tool/ruby/sys/linux.rs -1.6
qlty-cli/src/commands/plugins/disable.rs 81.0

Copy link
Member

@brynary brynary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks

@brynary brynary merged commit 86cce0d into main Nov 26, 2024
8 of 10 checks passed
@brynary brynary deleted the ma/add_plugins_disable branch November 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants