Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3860] Dotfiles Update for Repositories: Version 10.0 #220

Closed
wants to merge 2 commits into from
Closed

[3860] Dotfiles Update for Repositories: Version 10.0 #220

wants to merge 2 commits into from

Conversation

liuhehe1995
Copy link

@liuhehe1995 liuhehe1995 marked this pull request as draft December 1, 2023 03:27
@liuhehe1995 liuhehe1995 marked this pull request as ready for review December 1, 2023 03:36
@liuhehe1995 liuhehe1995 marked this pull request as draft December 1, 2023 03:37
@liuhehe1995 liuhehe1995 marked this pull request as ready for review December 1, 2023 04:20
@liuhehe1995
Copy link
Author

This PR came up with a problem I couldn't solve and have asked Lin for help.

@liuhehe1995
Copy link
Author

liuhehe1995 commented Dec 1, 2023 •
edited
Loading

For Pre－commit failed,
pre-commit run --all-files is successful in my local env.
image
image

@liuhehe1995
Copy link
Author

@kanda999 さん
For OCB failed, Lin's advice is add website_product_stock module in test-requirements.txt
But website_product_stock is exist in pci-private.
Now we've come up with 2 solutions:
1,Move website_product_stock module from private to custom
2,Split the module
Lin told me to ask you what to do.
Can you tell me what I'm supposed to do?

@AungKoKoLin1997
Copy link
Contributor

I take over this PR.

@AungKoKoLin1997
Copy link
Contributor

The pre-commit is run successfully in our local env but I plan to take care the tests CI failure because it is related with module dependency and cant finish in short time.

yostashiro
yostashiro reviewed Jul 4, 2024
View reviewed changes
fix_product_attribute_line_name_search/models/product_attribute_line_hook_name_search.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an addition of this entire file in this PR?

mrp_bom_component_menu/__manifest__.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why an addition of this entire file in this PR?

@AungKoKoLin1997 AungKoKoLin1997 self-requested a review July 8, 2024 03:31
@AungKoKoLin1997
Copy link
Contributor

Superseded by #218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yostashiro yostashiro yostashiro left review comments

@kanda999 kanda999 Awaiting requested review from kanda999

@rinaldifirdaus rinaldifirdaus Awaiting requested review from rinaldifirdaus

@AungKoKoLin1997 AungKoKoLin1997 Awaiting requested review from AungKoKoLin1997

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuhehe1995 @AungKoKoLin1997 @yostashiro