Place before namespace if no include found #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,8 @@ module CppAutoInclude | |||
| VIM::lines.each_with_index do |l, i| | |||
| if l =~ /^\s*#\s*include/ | |||
| includes << [l, i+1] | |||
| elsif l =~ /^\s*namespace/ and includes.length == 1 | |||
| includes << ['', i] | |||
There was a problem hiding this comment.
Just change the line number of the place holder:
includes[0][-1] = i
This will save some bytes especially when there are multiple namespaces
|
Nice catch 😃 Thanks! |
In case you use this in header files, it would be better to look for a namespace declaration then putting it on top, where the guard header should be.
m42e
force-pushed
the
include_placement
branch
from
8600479 to
e0aae75
Compare
|
Done, even if I didn't really get what is happening there ... :D I'm not to familiar with ruby |
|
would you mind merging the pull requests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you use this in header files, it would be better to look for a
namespace declaration then putting it on top, where the guard header
should be.