Always represent zero accurately in v1 histogram #3731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyunggeun Lee <[email protected]>
Signed-off-by: Kyunggeun Lee <[email protected]>
quic-kyunggeu
requested review from
quic-akhobare,
quic-klhsieh and
quic-mtuttle
quic-akhobare
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current V1 histogram fails to represent zero accurately.
This means it fails to discriminate signed vs. unsigned, and hence fails to properly generate the so-called "unsigned symmetric" encoding.
Therefore in this PR, I made v1 histogram always represent zero accurately.