Error logs, initialization of variables and deinit optimizations #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inc/fastrpc_ioctl.h
Outdated
| int *pfds = NULL; \ | ||
| unsigned *pattrs = NULL; \ |
There was a problem hiding this comment.
pfds and pattrs are not really used
There was a problem hiding this comment.
Arent these used in the invoke function?
src/adsp_default_listener.c
Outdated
| @@ -48,6 +57,133 @@ static domain_t *get_domain_uri(int domain_id) { | |||
| return NULL; | |||
| } | |||
|
|
|||
| #ifdef ENABLE_UPSTREAM_DRIVER_INTERFACE | |||
There was a problem hiding this comment.
is this featurization still needed?
src/fastrpc_apps_user.c
Outdated
| unsigned int length = 0; | ||
| int nErr = AEE_SUCCESS; | ||
|
|
||
| VERIFY(uri); |
There was a problem hiding this comment.
indentation seems off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using variable without initializing
Disable warning logs for LE
Optimize listener de-init by reducing remote calls