Resolved Unsigned-pd support issue #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/fastrpc_apps_user.c
Outdated
|
|
||
| if(IS_SESSION_OPEN_ALREADY(domain)) { | ||
| *dev = hlist[domain].dev; | ||
| return 0; |
There was a problem hiding this comment.
indentation does not look correct
src/fastrpc_apps_user.c
Outdated
| close(dev); | ||
| int fastrpc_session_close(int domain, int dev) { | ||
| if(hlist[domain].dev == -1) | ||
| close(dev); |
There was a problem hiding this comment.
use uniform indentation
src/fastrpc_cap.c
Outdated
| @@ -125,7 +125,7 @@ int fastrpc_get_cap(uint32_t domain, uint32_t attributeID, uint32_t *capability) | |||
|
|
|||
| bail: | |||
| if(dev != -1) | |||
| fastrpc_session_close(dev); | |||
| fastrpc_session_close(dom, dev); | |||
There was a problem hiding this comment.
use uniform indentation
quic-cgettibo
force-pushed
the
new_branch
branch
2 times, most recently
from
8f15e32 to
5ca3b56
Compare
quic-cgettibo
force-pushed
the
new_branch
branch
2 times, most recently
from
decb1d4 to
6f65b50
Compare
src/fastrpc_apps_user.c
Outdated
| @@ -342,6 +342,12 @@ void set_thread_context(int domain) { | |||
|
|
|||
| int fastrpc_session_open(int domain, int *dev) { | |||
| int device = -1; | |||
|
|
|||
| if(IS_SESSION_OPEN_ALREADY(domain)) { | |||
There was a problem hiding this comment.
use space for indentation instead of tab
There was a problem hiding this comment.
also give a space between if and (
src/fastrpc_apps_user.c
Outdated
| int fastrpc_session_close(int dev) { | ||
| close(dev); | ||
| int fastrpc_session_close(int domain, int dev) { | ||
| if(hlist[domain].dev == -1) |
There was a problem hiding this comment.
use space for indentation and space after "if"
Signed-off-by: Chanikya Prakash Gettiboina <[email protected]>
quic-ekangupt
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.