Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proposal.md using pyquil quilt-demo branch changes #48

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

notmgsk
Copy link
Member

@notmgsk notmgsk commented Nov 3, 2020

TODO:

  • Include the updated Quil.g4
  • Get feedback

Copy link
Member Author

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NONBLOCKING section could maybe be improved. It leads by saying that in some cases you may want to allow concurrent/simultaneous pulses on the same qubit and that this can be achieved with NONBLOCKING. But then finishes with saying that two consecutive NONBLOCKING PULSE 0 "xy" ... would require serial execution. It is mentioned between these two statements that the NONBLOCKING modifier does not exclude pulse operations on other frames but I think that should emphasised immediately and repeatedly

rfcs/analog/proposal.md Show resolved Hide resolved
|-----------|-----------------------------------|-----------------------|-----------------------|
| Frequency | INITIAL-FREQUENCY in DEFFRAME | Real numbers | Yes |
| Phase | 0.0 | Real numbers | Yes |
| Scale | 1.0 | Real numbers | Yes |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frequency and Scale are now marked as Yes under Can be parameterized?. Are there examples of this in the proposal?

```
# Simple capture of an IQ point
DECLARE iq REAL[2]
CAPTURE 0 "ro" flat(duration: 1e-6, iq: 2+3i) iq
CAPTURE 0 "ro" boxcar_kernel(duration: 1e-6) iq
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor

@kalzoo kalzoo Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great question, esp as IIRC boxcar_kernel is not in fact supported yet in the translator?

rfcs/analog/proposal.md Outdated Show resolved Hide resolved
rfcs/analog/proposal.md Show resolved Hide resolved
rfcs/analog/proposal.md Outdated Show resolved Hide resolved
@@ -374,6 +364,19 @@ SET-SCALE 0 "cz" 0.45
PULSE 0 1 "cz" erfsquare(duration: 100e-9, risetime: 20e-9, padleft: 0, padright: 0)
```

Active Reset Calibration:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentionally removed from the proposal (in the pyquil version)? @kilimanjaro

DELAY qubit 60e-9
LABEL end
```

## FAQs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FAQ was not present in the pyquil document. Was that intentional @kilimanjaro?

@notmgsk notmgsk marked this pull request as ready for review November 6, 2020 15:08
@notmgsk
Copy link
Member Author

notmgsk commented Nov 6, 2020

@kalzoo Shall we merge this, and move over any comments into the main PR? Then onto addressing #45 and merging in spec_changes.md.

@kalzoo
Copy link
Contributor

kalzoo commented Nov 9, 2020

@kalzoo Shall we merge this, and move over any comments into the main PR? Then onto addressing #45 and merging in spec_changes.md.

Sure, sounds good

@notmgsk notmgsk merged commit 1ded0f4 into bugfix/quilt-rfc-improvements Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants