TsumBeta: Release v68 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a script error when script wants to play another game immediately after it played one. With commit c84b088 page navigation became more object-orientated, but the navigation to "play game" did not reflect that change. Renaming "ProfilePage" to "ProfilePageJp" works with the new approach but breaks the old logic where at least one page key must exist per page name. This commit removes the last piece of the old page navigation logic.
This was referenced Jun 30, 2024
Merged
Sean-Hsueh
approved these changes
Jul 2, 2024
|
We receive some user feedbacking the same issue, thanks a lot for the fix 🫡 |
|
This closed #530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a script error when script wants to play another game immediately after it played one.
With commit c84b088 page navigation became more object-orientated, but the navigation to "play game" did not reflect that change. Renaming "ProfilePage" to "ProfilePageJp" works with the new approach but breaks the old logic where at least one page key must exist per page name. This commit removes the last piece of the old page navigation logic.
This slipped through my testing because my values for "Wait time (min) before repeat" is at least once "1", so my script never started a new game immediately after another finished. Mea culpa 😞
@Sean-Hsueh please review and merge as this sadly crashes the script for all players who have autoplay active and all values for "Wait time (min) before repeat" higher than 1.