New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize mint fee distribution and add zero fee check #293

Open

crStiv wants to merge 2 commits into rabbitholegg:main from crStiv:fix

crStiv commented Jan 17, 2025

This commit improves the mint fee distribution mechanism in QuestFactory:

Add zero mint fee validation check
Improve precision of fee calculations using multiplication
Optimize remainder distribution to avoid wei loss
Add explanatory comments for fee distribution logic

These changes ensure more accurate fee distribution and prevent potential
issues with zero fees while maintaining full backward compatibility.

crStiv added 2 commits

January 17, 2025 21:36


          Update QuestFactory.sol


          Update QuestFactory.sol

e03ccca

crStiv requested a review from a team as a code owner

January 17, 2025 20:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet