Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #685

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #685

wants to merge 1 commit into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Sep 29, 2024

This is an automated change generated by Resyntax.

Pass 1

Applied 2 fixes to drracket/drracket/private/syncheck/online-comp.rkt

  • Line 2, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 70, when-expression-in-for-loop-to-when-keyword: Use the #:when keyword instead of when to reduce loop body indentation.

Applied 11 fixes to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 385, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2141, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2192, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2356, inline-unnecessary-define: This variable is returned immediately and can be inlined.
  • Line 2464, define-lambda-to-define: The define form supports a shorthand for defining functions.
  • Line 2612, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2640, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2650, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2726, cond-let-to-cond-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2755, flat-contract-migration: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.

Applied 1 fix to drracket/drracket/private/syncheck/intf.rkt

  • Line 3, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Pass 2

Applied 5 fixes to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.
  • Line 387, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2142, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2640, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.
  • Line 2650, let-to-define: Internal definitions are recommended instead of let expressions, to reduce nesting.

Pass 3

Applied 1 fix to drracket/drracket/private/syncheck/gui.rkt

  • Line 21, tidy-require: Keep imports in require sorted and grouped by phase, with collections before files.

Summary

Fixed 20 issues in 3 files.

  • Fixed 10 occurrences of let-to-define
  • Fixed 5 occurrences of tidy-require
  • Fixed 1 occurrence of inline-unnecessary-define
  • Fixed 1 occurrence of define-lambda-to-define
  • Fixed 1 occurrence of cond-let-to-cond-define
  • Fixed 1 occurrence of flat-contract-migration
  • Fixed 1 occurrence of when-expression-in-for-loop-to-when-keyword

This is an automated change generated by Resyntax.

#### Pass 1

Applied 2 fixes to [`drracket/drracket/private/syncheck/online-comp.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/online-comp.rkt)

  * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
  * Line 70, `when-expression-in-for-loop-to-when-keyword`: Use the `#:when` keyword instead of `when` to reduce loop body indentation.

Applied 11 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt)

  * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
  * Line 385, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2141, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2192, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2356, `inline-unnecessary-define`: This variable is returned immediately and can be inlined.
  * Line 2464, `define-lambda-to-define`: The `define` form supports a shorthand for defining functions.
  * Line 2612, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2640, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2650, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2726, `cond-let-to-cond-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2755, `flat-contract-migration`: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.

Applied 1 fix to [`drracket/drracket/private/syncheck/intf.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/intf.rkt)

  * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.

#### Pass 2

Applied 5 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt)

  * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.
  * Line 387, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2142, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2640, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.
  * Line 2650, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting.

#### Pass 3

Applied 1 fix to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt)

  * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files.

## Summary

Fixed 20 issues in 3 files.

  * Fixed 10 occurrences of `let-to-define`
  * Fixed 5 occurrences of `tidy-require`
  * Fixed 1 occurrence of `inline-unnecessary-define`
  * Fixed 1 occurrence of `define-lambda-to-define`
  * Fixed 1 occurrence of `cond-let-to-cond-define`
  * Fixed 1 occurrence of `flat-contract-migration`
  * Fixed 1 occurrence of `when-expression-in-for-loop-to-when-keyword`
Comment on lines -2371 to +2381
(set! report-error-panel (new-horizontal-panel%
[parent report-error-parent-panel]
[stretchable-height #f]
[alignment '(center center)]
[style '(border)]))
(set! report-error-panel
(new-horizontal-panel% [parent report-error-parent-panel]
[stretchable-height #f]
[alignment '(center center)]
[style '(border)]))
(send report-error-parent-panel change-children (λ (l) null))
(let ([message-panel (new-vertical-panel%
[parent report-error-panel]
[stretchable-width #f]
[stretchable-height #f]
[alignment '(left center)])])
(let ([message-panel (new-vertical-panel% [parent report-error-panel]
[stretchable-width #f]
[stretchable-height #f]
[alignment '(left center)])])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These formatting changes, and the ones below, are because the inline-unnecessary-define rule reformatted this entire definition context. Opened jackfirth/resyntax#339 to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant