-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Resyntax fixes #685
Open
resyntax-ci
wants to merge
1
commit into
master
Choose a base branch
from
autofix-60-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated change generated by Resyntax. #### Pass 1 Applied 2 fixes to [`drracket/drracket/private/syncheck/online-comp.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/online-comp.rkt) * Line 2, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 70, `when-expression-in-for-loop-to-when-keyword`: Use the `#:when` keyword instead of `when` to reduce loop body indentation. Applied 11 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 385, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2141, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2192, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2356, `inline-unnecessary-define`: This variable is returned immediately and can be inlined. * Line 2464, `define-lambda-to-define`: The `define` form supports a shorthand for defining functions. * Line 2612, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2640, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2650, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2726, `cond-let-to-cond-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2755, `flat-contract-migration`: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now. Applied 1 fix to [`drracket/drracket/private/syncheck/intf.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/intf.rkt) * Line 3, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. #### Pass 2 Applied 5 fixes to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. * Line 387, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2142, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2640, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. * Line 2650, `let-to-define`: Internal definitions are recommended instead of `let` expressions, to reduce nesting. #### Pass 3 Applied 1 fix to [`drracket/drracket/private/syncheck/gui.rkt`](../blob/HEAD/drracket/drracket/private/syncheck/gui.rkt) * Line 21, `tidy-require`: Keep imports in `require` sorted and grouped by phase, with collections before files. ## Summary Fixed 20 issues in 3 files. * Fixed 10 occurrences of `let-to-define` * Fixed 5 occurrences of `tidy-require` * Fixed 1 occurrence of `inline-unnecessary-define` * Fixed 1 occurrence of `define-lambda-to-define` * Fixed 1 occurrence of `cond-let-to-cond-define` * Fixed 1 occurrence of `flat-contract-migration` * Fixed 1 occurrence of `when-expression-in-for-loop-to-when-keyword`
jackfirth
reviewed
Sep 29, 2024
Comment on lines
-2371
to
+2381
(set! report-error-panel (new-horizontal-panel% | ||
[parent report-error-parent-panel] | ||
[stretchable-height #f] | ||
[alignment '(center center)] | ||
[style '(border)])) | ||
(set! report-error-panel | ||
(new-horizontal-panel% [parent report-error-parent-panel] | ||
[stretchable-height #f] | ||
[alignment '(center center)] | ||
[style '(border)])) | ||
(send report-error-parent-panel change-children (λ (l) null)) | ||
(let ([message-panel (new-vertical-panel% | ||
[parent report-error-panel] | ||
[stretchable-width #f] | ||
[stretchable-height #f] | ||
[alignment '(left center)])]) | ||
(let ([message-panel (new-vertical-panel% [parent report-error-panel] | ||
[stretchable-width #f] | ||
[stretchable-height #f] | ||
[alignment '(left center)])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These formatting changes, and the ones below, are because the inline-unnecessary-define
rule reformatted this entire definition context. Opened jackfirth/resyntax#339 to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated change generated by Resyntax.
Pass 1
Applied 2 fixes to
drracket/drracket/private/syncheck/online-comp.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.when-expression-in-for-loop-to-when-keyword
: Use the#:when
keyword instead ofwhen
to reduce loop body indentation.Applied 11 fixes to
drracket/drracket/private/syncheck/gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.inline-unnecessary-define
: This variable is returned immediately and can be inlined.define-lambda-to-define
: Thedefine
form supports a shorthand for defining functions.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.cond-let-to-cond-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.flat-contract-migration
: flat-contract is a legacy form for constructing contracts from predicates; predicates can be used directly as contracts now.Applied 1 fix to
drracket/drracket/private/syncheck/intf.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.Pass 2
Applied 5 fixes to
drracket/drracket/private/syncheck/gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.let-to-define
: Internal definitions are recommended instead oflet
expressions, to reduce nesting.Pass 3
Applied 1 fix to
drracket/drracket/private/syncheck/gui.rkt
tidy-require
: Keep imports inrequire
sorted and grouped by phase, with collections before files.Summary
Fixed 20 issues in 3 files.
let-to-define
tidy-require
inline-unnecessary-define
define-lambda-to-define
cond-let-to-cond-define
flat-contract-migration
when-expression-in-for-loop-to-when-keyword