Automated Resyntax fixes #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Keep imports in `require` sorted and grouped by phase, with collections before files.
This quasiquotation is equialent to a simple `list` call.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Using `cond` instead of `if` here makes `begin` unnecessary
This `map` operation can be replaced with a `for/list` loop.
This `ormap` operation can be replaced with a `for/or` loop.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This `let` expression can be pulled up into a `define` expression.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
|
@jackfirth Is there a way to tell Resyntax to stop making a PR if there's already a pending PR? This PR and #461 touch a similar set of files, and I think it's not productive for reviewers to go through the the diff twice. |
|
@sorawee Not yet. Can you open an issue in the autofixer repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 9 files.
tidy-requireif-begin-to-condquasiquote-to-listmap-to-forif-let-to-condwhen-expression-in-for-loop-to-when-keywordormap-to-for/oror-hash-ref-set!-to-hash-ref!define-let-to-double-defineprovide/contract-to-contract-out