Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #1422

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #1422

wants to merge 12 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Dec 27, 2024

Resyntax fixed 50 issues in 20 files.

  • Fixed 24 occurrences of single-clause-match-to-match-define
  • Fixed 9 occurrences of tidy-require
  • Fixed 3 occurrences of read-line-any
  • Fixed 3 occurrences of if-else-false-to-and
  • Fixed 2 occurrences of define-simple-macro-to-define-syntax-parse-rule
  • Fixed 2 occurrences of sort-with-keyed-comparator-to-sort-by-key
  • Fixed 2 occurrences of zero-comparison-to-positive?
  • Fixed 2 occurrences of let-to-define
  • Fixed 1 occurrence of if-begin-to-cond
  • Fixed 1 occurrence of inverted-unless
  • Fixed 1 occurrence of begin0-let-to-define-begin0

resyntax-ci bot added 12 commits December 27, 2024 00:30
This `match` expression can be simplified using `match-define`.
The `define-simple-macro` form has been renamed to `define-syntax-parse-rule`.
This expression is equivalent to calling the `positive?` predicate.
The `let` expression in this `begin0` form can be extracted into the surrounding definition context.
Keep imports in `require` sorted and grouped by phase, with collections before files.
This negated `unless` expression can be replaced by a `when` expression.
Specify a line mode of `'any` with `read-line` to avoid differences between Windows and other platforms.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `if` expression can be refactored to an equivalent expression using `and`.
Using `cond` instead of `if` here makes `begin` unnecessary
This `sort` expression can be replaced with a simpler, equivalent expression.
This `if` expression can be refactored to an equivalent expression using `and`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants