Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing round updates for stream transactions #801

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix missing round updates for stream transactions #801

merged 3 commits into from
Oct 11, 2024

Conversation

PawelPawelec-RDX
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-database-migrations:HEAD-a958511-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-gateway-api:HEAD-a958511-arm64

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

Docker tags
docker.io/radixdlt/private-babylon-ng-data-aggregator:HEAD-a958511-arm64

@PawelPawelec-RDX PawelPawelec-RDX changed the base branch from develop to do-not-index-manifest-for-failed-transactions October 11, 2024 10:42
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the fix-missing-round-updates-for-stream-transactions branch 2 times, most recently from b258297 to f62cad7 Compare October 11, 2024 10:45
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the do-not-index-manifest-for-failed-transactions branch from 27529c7 to 3193f8e Compare October 11, 2024 11:13
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the fix-missing-round-updates-for-stream-transactions branch from f62cad7 to ac04ea2 Compare October 11, 2024 11:25
Base automatically changed from do-not-index-manifest-for-failed-transactions to develop October 11, 2024 13:31
dhedey
dhedey approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with a couple of questions around the origin type.

Also, just to check, we're adding some tests for the "All" kind filter?

CHANGELOG.md Outdated Show resolved Hide resolved
...edgerExtension/Processors/LedgerTransactionMarkers/OriginLedgerTransactionMarkerProcessor.cs Show resolved Hide resolved
...edgerExtension/Processors/LedgerTransactionMarkers/OriginLedgerTransactionMarkerProcessor.cs Show resolved Hide resolved
@PawelPawelec-RDX PawelPawelec-RDX force-pushed the fix-missing-round-updates-for-stream-transactions branch from ac04ea2 to 8fddeba Compare October 11, 2024 13:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PawelPawelec-RDX PawelPawelec-RDX merged commit f9b83ec into develop Oct 11, 2024
16 checks passed
@PawelPawelec-RDX PawelPawelec-RDX deleted the fix-missing-round-updates-for-stream-transactions branch October 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhedey dhedey dhedey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PawelPawelec-RDX @dhedey