-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Sargon HostInteractor #1447
Open
matiasbzurovski
wants to merge
54
commits into
main
Choose a base branch
from
ABW-3853-signatures-collector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # RadixWallet.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
matiasbzurovski
commented
Jan 24, 2025
@@ -1,505 +1,101 @@ | |||
import ComposableArchitecture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend just reviewing the new file rather than the diff for this reducer and its view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3853
Jira ticket: ABW-4133
Description
This PR implements Sargon's
HostInteractor
, which is required in order to make usage of theKeysCollector
&SignaturesCollector
inside Sargon. This allows us to delegate any operation that requires keys derivation/signatures into Sargon (e.g. Create an Account, Create a Persona, Sign a Transaction, etc).Internally, Sargon will use the mentioned
HostInteractor
, that will just present the corresponding UI and either sign/derive the public keys for the corresponding input.Pending items
Now that the
DerivePublicKeys
&Signing
views are presented via theOverlayWindowClient
, we need to update how these two views handle the errors. We cannot just doerrorQueue.schedule(error)
, because the corresponding error alert wouldn't be presented until the currentDerivePublicKeys
/Signing
view is dismissed (since they are all presented sequentially from the same list determined by theOverlayWindowClient
). I still need to update the handling for them.###Future updates
The
FactorSourceAccess
has been briefly updated for this PR, but the updates to handle new Factor Sources and contexts will be done in a future PR.How to test
Try any flow that can require keys derivation or signatures and verify it works as expected 🙂
As a reference, I am adding below some example videos for different flows that are now handled via Sargon.
Example flows
DeviceFactorSource
. Video