Authorization Interactor #356
Conversation
micbakos-rdx
added
Swift 🍏
micbakos-rdx
requested review from
CyonAlexRDX,
GhenadieVP,
giannis-rdx,
danvleju-rdx,
sergiupuhalschi-rdx and
matiasbzurovski
| match authorization { | ||
| AuthorizationResponse::Rejected => { | ||
| debug!("User rejected authorization, aborting."); | ||
| return Err(CommonError::HostInteractionAborted); |
There was a problem hiding this comment.
Good! We auth before consuming instances in Cache, perfect
There was a problem hiding this comment.
Do we have any unit test that fails if you would move up consume to be called before auth?
Otherwise I prefer it if you can add such a unit test :)
Typically create an account, Alice
Try creating account and abort/reject.
Try crating account, Bob, again this time Auth.
Assert that Bobs VECI derivation entity Index is that of Alice+1 and not +2.
Should do it right?
And then analogously for Persona
There was a problem hiding this comment.
Interesting, will try that, indeed adds value.
There was a problem hiding this comment.
Take a look at the last commits. I had to change a bit the API of the TestAuthorizationInteractor.
There was a problem hiding this comment.
No, sorry waiting for pre-commit
There was a problem hiding this comment.
You can check now
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 1169 1170 +1
Lines 26153 26248 +95
Branches 81 81
=======================================
+ Hits 24217 24305 +88
- Misses 1925 1932 +7
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces
micbakos-rdx
added
Rust 🦀
A new interactor responsible for asking the user through the host to authorise an operation. Such operation is called
AuthorizationPurposeand it currently supports variants for creating one or batch accounts, or one or batch personas.If the user rejects authorization, then such operation does not mutate the profile, nor does consume the cache.The user can either
AuthorizationResponse::AuthorizedorAuthorizationResponse::Rejected.Note that, I also changed the name of the error used to be called
SigningRejectedtoHostInteractionAborted. It can be thrown by hosts when answering to the interactor callbacks, and returned back to the method that initiated the interaction. It is a "common result" that hosts receive and can just reset the UI for the user to try again.