-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for webseeds #164
base: master
Are you sure you want to change the base?
Conversation
@chros73, well before you try it, let me tell you what i think it does: it should:
it wont:
given that, if you'd like to test it, have at it. |
Thanks for the detailed comment. Do youbplan to modify the functionalty further or this is the last take? |
@chros73 no planned functionality changes |
I couldn't compile libtorrent :( :
I couldn't find the cause of the issue "quickly". I don't/won't have time to "play" with it in the near future, sorry. |
I played with it today and managed to compile it:
I had to add back setting CPPFLAGS into build script, otherwise the include CFLAGS doesn't get passed to libtool for some reason that I still don't understand why:
|
So, I tried out with an archive.org torrent and it seems to be working, but when I tried to create my own (creating with utorrent 2.2.1) it didn't download it. Have you tried it with your own torrent file? And does it deal with multi/single-file torrents as well, e.g. as in transmission?
Probably you meant throttle groups, and not choke groups.
|
@chros73 i made some torrents myself and you are right about it not working. i only handled when multiple urls were present. and i didn't handle url's not ending with a / for single-torrent files. |
Thanks for the update, I also updated my branch with it. I've attached torrent files to try out with, let's use this URL for testing (we can create lot of type of torrents from it, and they are small files):
A. It properly throws error to the log console if:
B. It's working with single file torrents:
C. I'm not sure about multi file torrents, what URL do we have to use in these cases? I created torrents from this content:
Impressive work, @naf419 ! :) |
@chros73 according to my reading of the getright spec, url-list entries can either be: multi-file torrents files follow the same rule, but also add the sub-file name to the end of the url. your TP-LINK-TL-WR842N-ND-V2.torrent didnt work because it ends in a slash, but already has the torrent name included in the url prefix. you used (my interpretation of) the correct url in the other 2 multi-file torrents by removing the torrent name. ETA: strangely, the url you wrote above would have worked, but the actual url in the torrent had a trailing / |
|
Ya, the one that didn't work for you had a trailing slash. Should have been like this (the url you wrote without the /) TP-LINK-TL-WR842N-ND-V2-corrected.zip |
You were right, sorry (I haven't looked in the generated torrent file): utorrent 2.2.1 added the trailing slash. :( So, it seems all the URL related issues are good now. A. I suggest to modify B. Although a lot still has to be done if you (we) want this to get merged. :( May I suggest to go through the web.* and webseed.* files of transmission and "steal" ideas to use in your tracker/controller, e.g. like this? I think these classes have to be finished first and then the rest of the integration can be dealt with. Thanks for your work! |
Yes, it gets the next desired chunk from the same pool of desired chunks as the peer requests do, so it should [untested] work fine in simultaneous cooperation with other seeding peers. RE: merge, i don't imagine it ever will, I just threw it up here for anyone who wanted to patch it in themselves |
Initial attempt.
I tried to follow the psuedo-spec at http://getright.com/seedtorrent.html
(Barely) Tested against archive.org samples.