Remove the workspace argument to various ECC interfaces #4555
+97
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/remove-ws-arg
branch
from
3a54e03 to
8704987
Compare
randombit
force-pushed
the
jack/remove-ws-arg
branch
from
8704987 to
26491ce
Compare
reneme
approved these changes
Jan 17, 2025
| secure_vector<uint8_t> mul_x_only(const EC_Scalar& scalar, | ||
| RandomNumberGenerator& rng, | ||
| std::vector<BigInt>& ws) const; | ||
| secure_vector<uint8_t> mul_x_only(const EC_Scalar& scalar, RandomNumberGenerator& rng) const; |
There was a problem hiding this comment.
For the record: This API was added recently and hence doesn't require a deprecation, correct?
There was a problem hiding this comment.
Correct.
If this ends up not making it for 3.7 I'll switch it to be like the others with a second deprecated function that ignores the arg
randombit
force-pushed
the
jack/remove-ws-arg
branch
from
26491ce to
449f252
Compare
This was a performance crutch for EC_Point and is no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a performance crutch for EC_Point and is no longer required.
This should not go into a release without #4554 as otherwise it would pessimize oddball curves