Modify new EC private key constructors to take EC_Scalar #4563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/new-new-ec-key-constructors
branch
from
f5fcb83 to
4bfc65f
Compare
In #4437 new EC private key constructors were added, allowing deprecation of a quite confusing combined keygen/load constructor. However these new constructors take their input as a BigInt rather than the underlying EC_Scalar. Since #4437 has not been included in a release yet we can change these to take EC_Scalar directly, and avoid further entrenchment of BigInt in EC related interfaces.
reneme
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4437 new EC private key constructors were added, allowing deprecation of a quite confusing combined keygen/load constructor. However these new constructors take their input as a BigInt rather than the underlying EC_Scalar.
Since #4437 has not been included in a release yet we can change these to take EC_Scalar directly, and avoid further entrenchment of BigInt in EC related interfaces.