Context support for ML-DSA and SLH-DSA #4567
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows controlling all details of how signatures are created, without having to stuff values into the single parameters string which was previously available.
Without this patch, clang seemed to miscompile the retrofitting of the PK_Signer() legacy constructor. valgrind complained about uninitialized memory when building with clang in -O2 and -O3 (didn't test -O1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-DSA and SLH-DSA allow for a custom context for domain separation. This PR adds support for this using the new (experimental) signature options interface.
This closes #4376 since pre-hashed variants are postponed for now (see #4376 (comment)).
Dependencies
TODOs