Migrated Dynamic AST Expression Trees in Benchmarks and Tests to use AST Tree #17697
+69
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…ee and made ast tree use unique_ptr in place of shared_ptr
lamarrr
changed the title
lamarrr
changed the title
lamarrr
added
improvement
vyasr
approved these changes
Jan 14, 2025
| @@ -588,12 +588,11 @@ class tree { | |||
| * @returns a reference to the added expression | |||
| */ | |||
| template <typename Expr, typename... Args> | |||
| Expr const& emplace(Args&&... args) | |||
| std::enable_if_t<std::is_base_of_v<expression, Expr>, Expr const&> emplace(Args&&... args) | |||
There was a problem hiding this comment.
Was this just tightening up requirements for better error-handling? Did you run into a specific problem without this?
There was a problem hiding this comment.
Yes, it was just tightening up requirements for better error-handling.
There was a problem hiding this comment.
I personally find adding a static_assert check in this case can achieve the same goal while offering clearer error information.
PointKernel
approved these changes
Jan 14, 2025
bdice
approved these changes
Jan 14, 2025
Co-authored-by: Bradley Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows-up and closes #17400.
This merge cleans up some of the ast tree expressions in CUDF's benchmarks and tests, specifically the dynamically constructed ones.
The other existing AST trees/expressions in the tests and benchmarks are linear and without complicated lifetimes.
Checklist