Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify building and testing configs #71

Merged

Conversation

jameslamb
Copy link
Member

This is exactly the same set of changes already approved in #69.

cugraph-docs was switched from private to public during the lifetime of that PR, which put CI into a state where that PR couldn't be merged: #69 (comment)


Development and the vision for this project has stabilized here quite a bit over the last few weeks, so I think it's a good time to simplify things.

This proposes the following:

  • removing configuration for codecov
    • (there are no tests running here)
  • removing patterns in CODEOWNERS that don't match any files
  • removing anything related to CUDA 11, pyproject.toml, or requirements.txt in dependencies.yaml and related files
    • this repo exclusively uses conda, and only a single major version of CUDA
  • updating to sphinx>=8 and breathe>=4.35
  • removing unnecessary files in ci/utils
    • these appear to have been copied from cugraph, but they're not needed as we don't do notebook testing here

Notes for Reviewers

How I tested this

Tested the update-version.sh changes like this:

./ci/release/update-version.sh '25.04.00'

git grep -E '25\.2'
git grep -E '25\.02'

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 7, 2025
@jameslamb jameslamb requested review from a team as code owners January 7, 2025 02:13
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 762731b into rapidsai:branch-25.02 Jan 7, 2025
9 checks passed
@jameslamb jameslamb deleted the packaging-simplification-v2 branch January 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants