-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify building and testing configs #71
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-25.02
from
jameslamb:packaging-simplification-v2
Jan 7, 2025
Merged
simplify building and testing configs #71
rapids-bot
merged 10 commits into
rapidsai:branch-25.02
from
jameslamb:packaging-simplification-v2
Jan 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Jan 7, 2025
acostadon
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
raydouglass
approved these changes
Jan 7, 2025
bdice
approved these changes
Jan 7, 2025
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is exactly the same set of changes already approved in #69.
cugraph-docs
was switched from private to public during the lifetime of that PR, which put CI into a state where that PR couldn't be merged: #69 (comment)Development and the vision for this project has stabilized here quite a bit over the last few weeks, so I think it's a good time to simplify things.
This proposes the following:
dependencies.yaml
and related filessphinx>=8
andbreathe>=4.35
ci/utils
cugraph
, but they're not needed as we don't do notebook testing hereNotes for Reviewers
How I tested this
Tested the
update-version.sh
changes like this: