Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flake8, clang tools from wholegraph CMake #103

Merged
merged 1 commit into from
Jan 7, 2025
Merged

remove flake8, clang tools from wholegraph CMake #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,22 +226,6 @@ endif()
if (BUILD_BENCHMARKS AND CMAKE_PROJECT_NAME STREQUAL PROJECT_NAME)
add_subdirectory(bench)
endif()
##############################################################################
# - code checker -------------------------------------------------------------

include(./cmake/CodeChecker.cmake)
set(CLANG_FORMAT_EXE "clang-format")
set(CLANG_TIDY_EXE "clang-tidy")
set(FLAKE8_EXE "flake8")
if(CLANG_TOOL_PATH)
set(CLANG_FORMAT_EXE ${CLANG_TOOL_PATH}/clang-format)
set(CLANG_TIDY_EXE ${CLANG_TOOL_PATH}/clang-tidy)
endif()
add_code_checks(
CWD ${PROJECT_SOURCE_DIR}
CLANG_FORMAT ${CLANG_FORMAT_EXE}
CLANG_TIDY ${CLANG_TIDY_EXE}
FLAKE8 ${FLAKE8_EXE})

##############################################################################
# - install targets ----------------------------------------------------------
Expand Down
56 changes: 0 additions & 56 deletions cpp/cmake/CodeChecker.cmake
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions python/pylibwholegraph/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,6 @@ message(VERBOSE "PYLIBWHOLEGRAPH: Enable detection of conda environment for depe
##############################################################################
# - Compiler options ---------------------------------------------------------

# this is needed for clang-tidy runs
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a cleanup, not a behavior change... this option is already set to ON earlier in the same file.

cugraph-gnn/python/pylibwholegraph/CMakeLists.txt

Line 43 in 71675d8

set(CMAKE_EXPORT_COMPILE_COMMANDS ON)

message(STATUS "PYLIBWHOLEGRAPH: DEFAULT_CXX_FLAGS='${DEFAULT_CXX_FLAGS}'")
message(STATUS "PYLIBWHOLEGRAPH: CXX_FLAGS='${CXX_FLAGS}'")
message(STATUS "PYLIBWHOLEGRAPH: CXX_DEFINITIONS='${CXX_DEFINITIONS}'")
Expand Down
Loading