Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Build Directory #107

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

alexbarghi-nv
Copy link
Member

Removes the build directory from cugraph-pyg which should not have been committed.

Copy link

copy-pr-bot bot commented Jan 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review January 10, 2025 21:45
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners January 10, 2025 21:45
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I double-checked and there is already a .gitignore rule preventing this:

build/

So I guess this must have been added with git commit -f or maybe before a .gitignore was checked in. Either way, looks like we're protected from it happening again.

Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 10, 2025
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 87455cf into rapidsai:branch-25.02 Jan 10, 2025
76 checks passed
@alexbarghi-nv alexbarghi-nv deleted the remove-unused-dir branch January 10, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants