Update API for node2vec and biased random walks #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # padded results. The flags 'legacy_result_type' and 'use_padding" should be | ||
| # removed. | ||
|
|
||
| if legacy_result_type or use_padding is False: |
There was a problem hiding this comment.
Note... it seems like the old mechanism (coalesced format) is not particularly helpful other than a modest savings in memory on a small result type anyway.
We don't intend to support that in the C++ code any longer. If we need to continue to support this old mechanism while it is deprecated before we can delete it I would suggest implementing something to convert the format within the python layer.
There was a problem hiding this comment.
We still have the old mechanism around and I deprecated the coalesced path in the python API. Since there is no real benefit of using the coalesced path, I suggest to not support in the new API. @rlratzel any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
closes #3277
closes #2558
closes #2559
closes #2560
closes #2561