Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thrust::get<0>() calls on a scalar variable. #4851

Open
wants to merge 4 commits into
base: branch-25.02
Choose a base branch
from

Conversation

seunghwak
Copy link
Contributor

Close Issue #4846

Remove thrust::get<0>() calls on integer type variables. This shouldn't compile but this successfully compiles in the current build environment, so this hasn't been detected.

@seunghwak seunghwak requested a review from a team as a code owner January 7, 2025 23:07
@seunghwak seunghwak self-assigned this Jan 7, 2025
@seunghwak seunghwak added bug Something isn't working non-breaking Non-breaking change labels Jan 7, 2025
@seunghwak seunghwak added this to the 25.02 milestone Jan 7, 2025
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need to update copyright year to pass CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuGraph non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Incorrect code in compute_vertex_renumber_map() in src/sampling/sampling_post_processing_impl.cuh
2 participants