-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development to Master for 3.6.0 #2174
Open
lrljoe
wants to merge
37
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Missing Test for getCustomSortingPillDirectionsLabel with invalid direction
* Add Custom FIlter Input Attributes, Cleanup Filter Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Enable InputAttributes for SelectFilter * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Tidy ComponentUtilities, Migrate ColumnSelectQueryString * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Tweaks for Sort Icon Styling * Move customIconAttributes into th * Further tweaks & tidying * Fixes for other TH Elements * Move Visuals tests to Visuals section, clean up tests --------- Co-authored-by: lrljoe <[email protected]>
* Ensure Default Sorting Is Shown in Pills * Fix styling * Fix return type --------- Co-authored-by: lrljoe <[email protected]>
* Add hasCollapsedColumns as Computed * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Separate Test Suites * Remove PHP8.1 From Test Suite * Adjust PHPUnit XML * Workflow Test Suite Fixes
* Tidy up Blade Class Definitions * Fix test class ordering
* Migrate Filter Code Appropriately * Fix styling * Test Fixes * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Migrate Filter Status into Own Trait * Fix styling * Update setFiltersStatus to protected * Fix styling * Restore filters behaviour to public --------- Co-authored-by: lrljoe <[email protected]>
* Add ConfigurableAreaConfigurationTest * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Tidy displayToolbarFilters Method * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add SortingConfiguration Missing Test * Fix styling * Force Workflows * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add test queryStringWithQueryString * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add SortingConfiguration Missing Test * Fix styling * Force Workflows * Fix styling * Add Missing Tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Tidy & Improve Collapsed Columns Behaviour * Fix styling * Add relevant tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Split ComponentUtilities into traits * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Add missing Columns Non Computed Test * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Migrating Search Methods into Separate Traits * Fix styling * PHPStan Fixes * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Optimize Header/Footer * Fix styling * Force TestRun * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
…sts (#2168) * Migrate methods and add some missing tests * Fix styling * Add Attribute Checks * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Clean up Column Component View and Slot behaviours * Fix styling * Restore Trait --------- Co-authored-by: lrljoe <[email protected]>
* Add initial tests for LivewireComponentArrayFilter * Fix styling * Add LivewireComponentArrayFilter isEmpty check * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Centralise tests on base classes * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
* Adjustments for ComponentColumn * Fix styling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
============================================
+ Coverage 90.47% 91.44% +0.96%
- Complexity 1945 1995 +50
============================================
Files 201 212 +11
Lines 4388 4499 +111
============================================
+ Hits 3970 4114 +144
+ Misses 418 385 -33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PENDING FINAL TESTS
[v3.6.0] - UNRELEASED
Bug Fixes
Tweaks
Testing