Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development to Master for 3.6.0 #2174

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

Development to Master for 3.6.0 #2174

wants to merge 37 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 11, 2025

PENDING FINAL TESTS

[v3.6.0] - UNRELEASED

Bug Fixes

Tweaks

Testing

lrljoe and others added 30 commits December 16, 2024 03:03
Add Missing Test for getCustomSortingPillDirectionsLabel with invalid direction
* Add Custom FIlter Input Attributes, Cleanup Filter Tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Enable InputAttributes for SelectFilter

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Tidy ComponentUtilities, Migrate ColumnSelectQueryString

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Tweaks for Sort Icon Styling

* Move customIconAttributes into th

* Further tweaks & tidying

* Fixes for other TH Elements

* Move Visuals tests to Visuals section, clean up tests


---------

Co-authored-by: lrljoe <[email protected]>
* Ensure Default Sorting Is Shown in Pills

* Fix styling

* Fix return type

---------

Co-authored-by: lrljoe <[email protected]>
* Add hasCollapsedColumns as Computed

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Separate Test Suites

* Remove PHP8.1 From Test Suite

* Adjust PHPUnit XML

* Workflow Test Suite Fixes
* Tidy up Blade Class Definitions

* Fix test class ordering
* Migrate Filter Code Appropriately

* Fix styling

* Test Fixes

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Migrate Filter Status into Own Trait

* Fix styling

* Update setFiltersStatus to protected

* Fix styling

* Restore filters behaviour to public

---------

Co-authored-by: lrljoe <[email protected]>
* Add ConfigurableAreaConfigurationTest

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Tidy displayToolbarFilters Method

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add SortingConfiguration Missing Test

* Fix styling

* Force Workflows

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add test queryStringWithQueryString

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add SortingConfiguration Missing Test

* Fix styling

* Force Workflows

* Fix styling

* Add Missing Tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Tidy & Improve Collapsed Columns Behaviour

* Fix styling

* Add relevant tests

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Split ComponentUtilities into traits

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Add missing Columns Non Computed Test

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Migrating Search Methods into Separate Traits

* Fix styling

* PHPStan Fixes

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Optimize Header/Footer

* Fix styling

* Force TestRun

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
lrljoe and others added 7 commits January 11, 2025 04:22
…sts (#2168)

* Migrate methods and add some missing tests

* Fix styling

* Add Attribute Checks

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Clean up Column Component View and Slot behaviours

* Fix styling

* Restore Trait

---------

Co-authored-by: lrljoe <[email protected]>
* Add initial tests for LivewireComponentArrayFilter

* Fix styling

* Add LivewireComponentArrayFilter isEmpty check

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Centralise tests on base classes

* Fix styling

---------

Co-authored-by: lrljoe <[email protected]>
* Adjustments for ComponentColumn

* Fix styling
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 95.30516% with 30 lines in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (b2ddbb7) to head (6598b25).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../Traits/Helpers/LivewireComponentColumnHelpers.php 60.00% 10 Missing ⚠️
...ore/QueryStrings/HasQueryStringForColumnSelect.php 66.66% 8 Missing ⚠️
src/Traits/Core/Filters/HasFilterMenuStyling.php 89.65% 3 Missing ⚠️
src/Traits/Core/Filters/ManagesFilters.php 92.68% 3 Missing ⚠️
src/LaravelLivewireTablesServiceProvider.php 75.00% 2 Missing ⚠️
...raits/Core/Component/HandlesComputedProperties.php 77.77% 2 Missing ⚠️
src/Traits/WithSearch.php 92.30% 1 Missing ⚠️
src/Views/Traits/Columns/HasComponentView.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2174      +/-   ##
============================================
+ Coverage     90.47%   91.44%   +0.96%     
- Complexity     1945     1995      +50     
============================================
  Files           201      212      +11     
  Lines          4388     4499     +111     
============================================
+ Hits           3970     4114     +144     
+ Misses          418      385      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant