Use lazy arguments for when and whenNot #169
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is a small change/fix.
When using
when
as a shortcut for anif
, it violated my assumption that the conditional code would not be executed at all. Instead, it is executed but its result not used. Not a problem if your code is mostly pure, but if there are lurking some side effects, it can give you a hard time finding the problem. I did set the boolean correctly, did I?I suggest to use lazy parameters here, which makes usage of
when
as equivalent toìf
as possible.