fix: add missing dial codes data in i18nify-data [ ROW-408 ] (#179)

* fix: add missing fial codes data in i18nify-data * Create lazy-plants-confess.md * fix: fixed test data -- validated it from Google's libphonenumber * update codecov artifact version * update codecov download-artifact version
razorpay · Oct 17, 2024 · 934f6b5 · 934f6b5
1 parent e2e5d3f
commit 934f6b5
Show file tree

Hide file tree

Showing 4 changed files with 58 additions and 33 deletions.
diff --git a/.changeset/lazy-plants-confess.md b/.changeset/lazy-plants-confess.md
@@ -0,0 +1,5 @@
+---
+"@razorpay/i18nify-js": patch
+---
+
+fix: add missing dial codes data in i18nify-data
diff --git a/.github/workflows/i18nify-js-coverage.yml b/.github/workflows/i18nify-js-coverage.yml
@@ -44,13 +44,13 @@ jobs:
         working-directory: packages/i18nify-js
         run: yarn test
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           fail_ci_if_error: false
           verbose: true
       - name: Upload Unit Test Results
         if: always()
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: Unit Test Results
           path: src/coverage/**/*.xml
@@ -63,7 +63,7 @@ jobs:
     if: (success() || failure()) && ${{ needs.check-if-i18nify-js.outputs.modified == 'true' }}
     steps:
       - name: Download Artifacts
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
         with:
           path: artifacts
 

diff --git a/i18nify-data/phone-number/dial-code-to-country/data.json b/i18nify-data/phone-number/dial-code-to-country/data.json
@@ -22,9 +22,12 @@
       "PR",
       "TC",
       "TT",
+      "TF",
       "VC",
       "VG",
-      "VI"
+      "SX",
+      "VI",
+      "UM"
     ],
     "7": ["RU", "KZ"],
     "20": ["EG"],
@@ -39,10 +42,20 @@
     "40": ["RO"],
     "41": ["CH"],
     "43": ["AT"],
-    "44": ["GB", "GB-ENG", "GB-NIR", "GB-SCT", "GB-UKM", "GB-WLS"],
+    "44": [
+      "GB",
+      "GB-ENG",
+      "GB-NIR",
+      "GB-SCT",
+      "GB-UKM",
+      "GB-WLS",
+      "GG",
+      "IM",
+      "JE"
+    ],
     "45": ["DK"],
     "46": ["SE"],
-    "47": ["NO"],
+    "47": ["NO", "BV", "SJ"],
     "48": ["PL"],
     "49": ["DE"],
     "51": ["PE"],
@@ -54,10 +67,10 @@
     "57": ["CO"],
     "58": ["VE"],
     "60": ["MY"],
-    "61": ["AU"],
+    "61": ["AU", "CX", "CC"],
     "62": ["ID"],
     "63": ["PH"],
-    "64": ["NZ"],
+    "64": ["NZ", "PN"],
     "65": ["SG"],
     "66": ["TH"],
     "81": ["JP"],
@@ -72,7 +85,7 @@
     "95": ["MM"],
     "98": ["IR"],
     "211": ["SS"],
-    "212": ["MA"],
+    "212": ["MA", "EH"],
     "213": ["DZ"],
     "216": ["TN"],
     "218": ["LY"],
@@ -136,7 +149,7 @@
     "355": ["AL"],
     "356": ["MT"],
     "357": ["CY"],
-    "358": ["FI"],
+    "358": ["FI", "AX"],
     "359": ["BG"],
     "370": ["LT"],
     "371": ["LV"],
@@ -158,7 +171,7 @@
     "420": ["CZ"],
     "421": ["SK"],
     "423": ["LI"],
-    "500": ["FK"],
+    "500": ["FK", "GS"],
     "501": ["BZ"],
     "502": ["GT"],
     "503": ["SV"],
@@ -167,7 +180,7 @@
     "506": ["CR"],
     "507": ["PA"],
     "509": ["HT"],
-    "590": ["MF", "FW"],
+    "590": ["MF", "FW", "GP", "BL"],
     "591": ["BO"],
     "592": ["GY"],
     "593": ["EC"],
@@ -223,6 +236,13 @@
     "994": ["AZ"],
     "995": ["GE"],
     "996": ["KG"],
-    "998": ["UZ"]
+    "998": ["UZ"],
+    "672": ["AQ", "NF"],
+    "246": ["IO"],
+    "00672": ["HM"],
+    "596": ["MQ"],
+    "508": ["PM"],
+    "690": ["TK"],
+    "681": ["WF"]
   }
 }
diff --git a/packages/i18nify-js/src/modules/phoneNumber/__tests__/mocks/phoneNumbers.json b/packages/i18nify-js/src/modules/phoneNumber/__tests__/mocks/phoneNumbers.json
@@ -2872,83 +2872,83 @@
   "IO": [
     {
       "PhoneNumber": "+246-387-555-5",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-7",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-0",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-7",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-6",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-0",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-7",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-0",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-7",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-6",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-5",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-1",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-6",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-1",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-0",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-1",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-1",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-4",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-6",
-      "isValid": false
+      "isValid": true
     },
     {
       "PhoneNumber": "+246-387-555-1",
-      "isValid": false
+      "isValid": true
     }
   ],
   "BN": [