Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and cleanup deps #76

Merged
merged 7 commits into from
Nov 25, 2024
Merged

chore: update and cleanup deps #76

merged 7 commits into from
Nov 25, 2024

Conversation

rolandjitsu
Copy link
Collaborator

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

Updated versions for dev deps and cleaned up.

Does this PR introduce a breaking change?

No.

Other information

Depends on #75.

@rolandjitsu
Copy link
Collaborator Author

rolandjitsu commented Nov 11, 2024

I'll fix this up after #75 is merged. I may also take some of the changes in regards to prettier that @jonkoops has made in attr-accept.

@jonkoops
Copy link
Collaborator

Ping me when this is done and I will take some time to review the changes :)

@jonkoops
Copy link
Collaborator

@rolandjitsu could you give this a rebase and direct it towards the beta branch?

@rolandjitsu rolandjitsu changed the base branch from main to beta November 13, 2024 13:20
@rolandjitsu
Copy link
Collaborator Author

@rolandjitsu could you give this a rebase and direct it towards the beta branch?

I'll tend to this later this week. Most likely during the weekend as I'm a bit busy during the week.

@jonkoops
Copy link
Collaborator

Sure no problem.

eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.husky/commit-msg Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@jonkoops
Copy link
Collaborator

Let's also remove the .editorconfig like we did for file-selector as we can simply fall back to Prettier to take care if it for us.

@rolandjitsu
Copy link
Collaborator Author

Let's also remove the .editorconfig like we did for file-selector as we can simply fall back to Prettier to take care if it for us.

Actually, I'd like to keep it because of this rule:

end_of_line = lf
insert_final_newline = true

Prettier is not able to handle that (or at least I don't see it applied for any file I edit). Also, editorconfig applies the rules before you format, so at least spacing and and indent style will already be set to what you'd want.

@rolandjitsu rolandjitsu requested a review from jonkoops November 25, 2024 11:35
@jonkoops
Copy link
Collaborator

According to the Prettier documentation it should always insert a final newline in every file:

Empty lines at the start and end of blocks (and whole files) are removed. (Files always end with a single newline, though.)

I can confirm this is fixed when I run prettier --write ., and insert_final_newline is also listed as a redundant configuration option. So perhaps this is a problem with the IDE configuration? It seems the same is true for end_of_line, which defaults to lf in Prettier.

Either way it doesn't matter as it will get auto fixed as soon as a commit is made, and the formatting is also verified on CI. I would not worry too much about IDE specific issues, the important thing is that the code is consistent when committed.

Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but I still think we should remove the .editorconfig and fall back as much as possible to Prettier, also to keep things consistent between repos (such as file-selector), see #76 (comment).

Also the commit hook issue can be fixed by adding the prepare script for Husky, see #76 (comment).

.husky/pre-commit Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rolandjitsu rolandjitsu merged commit d041eda into beta Nov 25, 2024
4 checks passed
@rolandjitsu rolandjitsu deleted the chore/update-deps branch November 25, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants