-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update and cleanup deps #76
Conversation
Ping me when this is done and I will take some time to review the changes :) |
@rolandjitsu could you give this a rebase and direct it towards the |
I'll tend to this later this week. Most likely during the weekend as I'm a bit busy during the week. |
Sure no problem. |
8ad1dae
to
f2e8f91
Compare
b6131ef
to
8e2d4f8
Compare
Let's also remove the |
8e2d4f8
to
47bbb33
Compare
Actually, I'd like to keep it because of this rule:
Prettier is not able to handle that (or at least I don't see it applied for any file I edit). Also, editorconfig applies the rules before you format, so at least spacing and and indent style will already be set to what you'd want. |
According to the Prettier documentation it should always insert a final newline in every file:
I can confirm this is fixed when I run Either way it doesn't matter as it will get auto fixed as soon as a commit is made, and the formatting is also verified on CI. I would not worry too much about IDE specific issues, the important thing is that the code is consistent when committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I still think we should remove the .editorconfig
and fall back as much as possible to Prettier, also to keep things consistent between repos (such as file-selector
), see #76 (comment).
Also the commit hook issue can be fixed by adding the prepare
script for Husky, see #76 (comment).
47bbb33
to
5cf19b8
Compare
5cf19b8
to
c338dfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Updated versions for dev deps and cleaned up.
Does this PR introduce a breaking change?
No.
Other information
Depends on #75.