-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync main w/ beta #97
base: main
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: - node < 18, and CommonJS, are no longer supported
Signed-off-by: Jon Koops <[email protected]>
Signed-off-by: Jon Koops <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this contains some breaking changes, so let's not merge this until we are sure we want to do a major release.
Yeah, it needs a rebase. But that will mess up semantic-release as we discussed in file-selector. |
I think what we can do is backport fixes from
That way we don't have to deal with a nasty merge/rebase |
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
This PR will get all the changes from
beta
tomain
and trigger a major release.Does this PR introduce a breaking change?
Yes, there are a few breaking changes:
Other information