Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync main w/ beta #97

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: sync main w/ beta #97

wants to merge 11 commits into from

Conversation

rolandjitsu
Copy link
Collaborator

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary

This PR will get all the changes from beta to main and trigger a major release.

Does this PR introduce a breaking change?

Yes, there are a few breaking changes:

  1. The min required node version will be 18
  2. CommonJS is no longer supported

Other information

Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this contains some breaking changes, so let's not merge this until we are sure we want to do a major release.

@rolandjitsu
Copy link
Collaborator Author

Looks like this contains some breaking changes, so let's not merge this until we are sure we want to do a major release.

Yeah, it needs a rebase. But that will mess up semantic-release as we discussed in file-selector.

@jonkoops
Copy link
Collaborator

jonkoops commented Nov 26, 2024

I think what we can do is backport fixes from master to beta and then swap the branches when we decide to release so:

  • master becomes 2.x
  • beta becomes the new master

That way we don't have to deal with a nasty merge/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants