Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for community link #27

Merged
merged 2 commits into from
May 18, 2023
Merged

Update README.md for community link #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59192be
Update README.md for community link
moshfiqrony May 18, 2023
93e1c22
Update README.md
moshfiqrony May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ This repo contains the source code and documentation powering [bn.react.dev](htt

## Getting started

### Join the Bengali discord community
Hi dev, We are Bengali React doc translation community welcome you to join the discord server - https://github.com/reactjs/bn.react.dev/issues/26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have been the server link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhai I try to keep the issue as the main point for community link and update. That's why I added the issue intentionally. Like for progress we follow one issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! now I got it. I guess in that case we could make the code inline and a bit paraphrase like this?

Hi dev, we are Bengali React doc translation community. We welcome you to join our discord server.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd suggest making the line in the issue inline as well. Like...
Anyway, approving the PR.

Here is the discord server invitation link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! I thought approving wouldn't just merge it immediately. I am so sorry.


### Prerequisites

1. Git
Expand Down