Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed library book detail in Internet Explorer (XPath lib), see #70 #285

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

danielweck
Copy link
Member

Pull Request for #70

@danielweck
Copy link
Member Author

Proposed solution in this Pull Request: replace Jath with jQuery.XPath
Caveat: larger-than-needed additional library
Alternative suggestion: let's not use XPath, just parse the OPF metadata "manually"
@ryanackley what do you think?
Note that I initially attempted to fix Jath (to no avail), see comments here:
#70 (comment)

@larsvoigt
Copy link

Is your fix working @danielweck? Can your merge this into develop?
It would be awesome the ability to use the book detail in IE. Thanks Lars

@ryanackley
Copy link
Contributor

Sorry this one slipped through the cracks. @danielweck looking at the Jath issue, I think we just need to explicitly create the IE msxml object instead of a DOMParser for the case of IE.

@larsvoigt
Copy link

Fast response. I understand not completly the issue :-), but it sounds like you working on it.
Thank you @ryanackley

@danielweck
Copy link
Member Author

@larsvoigt you can use my pull request, but I am somehow reluctant to merge it. The jQuery.XPath library is quite large and complex, compared to Jath. Readium only requires XPath processing to extract metadata from the OPF package file, in the ebook library "info / details pane". A possible alternative would be to parse the OPF metadata without XPath, which would negate the need for an XPath library.

@danielweck
Copy link
Member Author

@ryanackley I didn't try very hard to patch Jath, I just did that:
#70 (comment)
(but as you can see, I gave up when I saw the other IE-related issues in Jath's issue tracker)

Could you please provide some details about the code changes you are suggesting?
Many thanks!

danielweck added a commit that referenced this pull request Sep 11, 2015
#285
library book detail in Internet Explorer (XPath lib)
Conflicts:
	lib/Readium.js
	require_config.js
@danielweck
Copy link
Member Author

Interestingly, Readium's current jath-based implementation works fine in Edge, but still breaks in Internet Explorer 11 (latest version on Windows 10).
So, the jxpath-based implementation in https://github.com/readium/readium-js-viewer/tree/feature/libraryBookDetailsIE is only needed for the legacy Trident web browser. Good.

@rkwright
Copy link
Contributor

Defer from 0.22 because this approach is too heavy-handed and needs a rewrite.

@rkwright rkwright removed bug labels May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants