-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed library book detail in Internet Explorer (XPath lib), see #70 #285
base: develop
Are you sure you want to change the base?
Conversation
Proposed solution in this Pull Request: replace Jath with jQuery.XPath |
Is your fix working @danielweck? Can your merge this into develop? |
Sorry this one slipped through the cracks. @danielweck looking at the Jath issue, I think we just need to explicitly create the IE msxml object instead of a DOMParser for the case of IE. |
Fast response. I understand not completly the issue :-), but it sounds like you working on it. |
@larsvoigt you can use my pull request, but I am somehow reluctant to merge it. The jQuery.XPath library is quite large and complex, compared to Jath. Readium only requires XPath processing to extract metadata from the OPF package file, in the ebook library "info / details pane". A possible alternative would be to parse the OPF metadata without XPath, which would negate the need for an XPath library. |
@ryanackley I didn't try very hard to patch Jath, I just did that: Could you please provide some details about the code changes you are suggesting? |
Conflicts: lib/Readium.js require_config.js
Interestingly, Readium's current |
Defer from 0.22 because this approach is too heavy-handed and needs a rewrite. |
Pull Request for #70