Skip to content

Commit

Permalink
Fix path to macOS binary in artifact bundle (#5957)
Browse files Browse the repository at this point in the history
  • Loading branch information
SimplyDanny authored Jan 13, 2025
1 parent 3f2b86c commit bd73b12
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
17 changes: 16 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,22 @@

#### Breaking

* None.
* If you are referring to the `swiftlint` binary from an Artifact Bundle consumed via Swift Package Manager
in an Xcode Run Script Build Phase, make sure to update the path from

```bash
"$SWIFT_PACKAGE_DIR"/swiftlintplugins/SwiftLintBinary/SwiftLintBinary.artifactbundle/swiftlint-*/bin/swiftlint
```

to

```bash
"$SWIFT_PACKAGE_DIR"/swiftlintplugins/SwiftLintBinary/SwiftLintBinary.artifactbundle/swiftlint-*-macos/bin/swiftlint
```

in order to make Xcode use the binary built for macOS.
[SimplyDanny](https://github.com/SimplyDanny)
[#5954](https://github.com/realm/SwiftLint/issues/5954)

#### Experimental

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ following way:

```bash
SWIFT_PACKAGE_DIR="${BUILD_DIR%Build/*}SourcePackages/artifacts"
SWIFTLINT_CMD=$(ls "$SWIFT_PACKAGE_DIR"/swiftlintplugins/SwiftLintBinary/SwiftLintBinary.artifactbundle/swiftlint-*/bin/swiftlint | head -n 1)
SWIFTLINT_CMD=$(ls "$SWIFT_PACKAGE_DIR"/swiftlintplugins/SwiftLintBinary/SwiftLintBinary.artifactbundle/swiftlint-*-macos/bin/swiftlint | head -n 1)

if test -f "$SWIFTLINT_CMD" 2>&1
then
Expand Down

0 comments on commit bd73b12

Please sign in to comment.