Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add materials for JupyterLab tutorial #445

Closed
wants to merge 3 commits into from
Closed

Conversation

eyrei123
Copy link
Contributor

@eyrei123 eyrei123 commented Oct 8, 2023

Collection of notebooks, markdown and other files for Using JupyterLab tutorial.

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Collection of notebooks, markdown and other files for Using JupyterLab tutorial.
@martin-martin martin-martin changed the title Add files via upload Add materials for JupyterLab tutorial Oct 9, 2023
@martin-martin martin-martin self-requested a review October 9, 2023 13:45
Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyrei123 the issues that you highlighted on Trello come from running black on the code in your notebooks.

If you take all the code in your notebooks, make sure that they're black-formatted, and that there aren't any superfluous empty cells at the bottom of the notebooks, then the checks should pass.

I demonstrated this with one of the files, Population Changes.ipynb, which now doesn't get flagged anymore.


Please also move all your files into a dedicated folder, and also move your README.md file there. Currently, everything is in the root folder.

@martin-martin
Copy link
Contributor

Closed in favor of #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants