Add google/latest endpoint #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F-X64
commented
Jun 26, 2024
| print(arch) | ||
| latest_image = ( | ||
| db.query(GoogleImage) | ||
| .filter(GoogleImage.arch.ilike(arch)) |
There was a problem hiding this comment.
This is interesting.
sqalchemy queries seem to be case sensitive by default (which is expected).
running a query like this will work:
"localhost:8000/google/latest?arch=ARM64"
but if I run this:
"localhost:8000/google/latest?arch=X86_64"
it will automatically be tranformed to "...x86_64" which will crash.
Used ilike comparison to mitigate.
There was a problem hiding this comment.
That's an interesting variance. 🤔
major
reviewed
Jun 26, 2024
cid/crud.py
Outdated
| ) | ||
| print(archs) |
There was a problem hiding this comment.
Did you intend to leave this print() here? 😜
cid/crud.py
Outdated
| return {"error": "No images found", "code": 404} | ||
| if latest_image is None: | ||
| print("No image found") | ||
| continue |
F-X64
force-pushed
the
add-google-latest-endpoint
branch
from
21d78d4 to
e4d43c2
Compare
major
approved these changes
Jun 27, 2024
Add google/latest Add optional arch param Add tests to validate function with or without supplying opptional param
F-X64
force-pushed
the
add-google-latest-endpoint
branch
from
e4d43c2 to
9d9d002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add google/latest
Add optional arch param
Add tests to validate function with or without supplying optional param