Add optional params to /azure #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional arch filter Add optional urn filter Add optional version filter Add find_azure_images crud function Add necessary testing
major
approved these changes
Jul 2, 2024
| """ | ||
| query = db.query(AzureImage).order_by(desc(AzureImage.version)) | ||
|
|
||
| if arch: |
There was a problem hiding this comment.
Ah, very slick low-code method for handling this. 👏
There was a problem hiding this comment.
For once it comes in handy that we have the date suffix in all image versions on Azure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add optional arch filter
Add optional urn filter
Add optional version filter
Add pagination
Add find_azure_images crud function
Add necessary testing
Example