Add transport args as a kwarg for HubProxy [RHELDST-27818] #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
requested changes
Nov 21, 2024
kobo/client/__init__.py
Outdated
| @@ -129,7 +129,8 @@ class ClientCommand(kobo.cli.Command): | |||
| class HubProxy(object): | |||
| """A Hub client (thin ServerProxy wrapper).""" | |||
|
|
|||
| def __init__(self, conf, client_type=None, logger=None, transport=None, auto_logout=None, **kwargs): | |||
| def __init__(self, conf, client_type=None, logger=None, auto_logout=None, | |||
There was a problem hiding this comment.
This change reorders some positional arguments. That's backwards-incompatible, can you please avoid that?
For example, if someone has written:
proxy = HubProxy(conf, "worker", logger, None, True)
Prior to this change, that True meant auto_logout=True.
When they upgrade to the kobo version with this change, it will instead mean transport=True and their code will crash.
We might hope that everyone has only used named arguments here, but it's not something we can assume.
We would like to be able to set the retry parameters for xml-rpc calls in pub. The retry_request decorator accepts kwargs for setting the retry parameters, but the HubProxy class doesn't make use of these. This change allows users to provide transport class args as a kwarg, so we can modify the retry behaviour.
amcmahon-rh
force-pushed
the
transport_args
branch
from
ee4972d to
200c1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to be able to set the retry parameters for xml-rpc calls in pub. The retry_request decorator accepts kwargs for setting the retry parameters, but the HubProxy class doesn't make use of these.
This change allows users to provide transport class args as a kwarg, so we can modify the retry behaviour.