Update Akka configuration to avoid registering JVM shutdown hooks and calling system exit on fatal error #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configures default logging levels, disables framework exit on fatal error (harness should do it) and disables JVM shutdown hooks (benchmark should handle it).
lbulej
force-pushed
the
topic/akka-config
branch
from
1b806ad to
4b4b38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures default logging levels, disables framework exit on fatal error (harness should do it) and disables JVM shutdown hooks (benchmark should handle it). The idea is that benchmark should not register global hooks that run outside the harness control. The benchmark appears to terminate the actor system properly, so there should be no need for Akka to do this.