Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuget): Support for variables #33416

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat(nuget): Support for variables #33416

wants to merge 10 commits into from
+45 −11

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jan 5, 2025

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from viceice and rarkins January 5, 2025 21:37
@zharinov zharinov mentioned this pull request Jan 6, 2025
Merged
6 tasks
rarkins
rarkins requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs deconflicting

@zharinov zharinov requested a review from rarkins January 9, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott left review comments

@viceice viceice Awaiting requested review from viceice

@rarkins rarkins Awaiting requested review from rarkins

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zharinov @AArnott @rarkins