Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel-module): support bazel_dep dependencies without the version parameter #33496

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reutermj
Copy link
Contributor

@reutermj reutermj commented Jan 9, 2025

Changes

This adds support for bazel_dep dependencies without the version parameter declared in MODULE.bazel files.

Context

MODULE.bazel files allow for bazel_dep dependencies to be declared without the version parameter. This is used in conjunction with overrides such as git_override, single_version_override, or local_path_override to provide the dependency version. Currently, renovate does not recognize overridden dependencies without the version parameter on the bazel_dep, and it requires a no-op version to be added to the bazel_dep to recognize the override and correctly update the override version.

Before:

# the MODULE.bazel in flecs does not declare a version parameter, but this is required for renovate
bazel_dep(name = "flecs", version = "0.0.0") 
git_override(
    module_name = "flecs",
    remote = "https://github.com/SanderMertens/flecs.git",
    commit = "8a1e9abe412eda7cd7f2a7440dac7499ce42cdca",
)

After:

bazel_dep(name = "flecs") 
git_override(
    module_name = "flecs",
    remote = "https://github.com/SanderMertens/flecs.git",
    commit = "8a1e9abe412eda7cd7f2a7440dac7499ce42cdca",
)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant