feat: issuePermissions flow with safe7579 user operation builder #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
Comment on lines
166
to
197
| console.log(`isAccountDeployed = false`) | ||
| console.log(`Deploying and setting up Safe7579 account...`) | ||
| const setUpAndExecuteUserOpHash = await this.setupSafe7579AndExecute( | ||
| initialCallsAtSafeSetupPhase | ||
| ) | ||
| await this.bundlerClient.waitForUserOperationReceipt({ | ||
| hash: setUpAndExecuteUserOpHash | ||
| }) | ||
| console.log(`Deployment completed.`) | ||
| } | ||
| console.log(`isAccountDeployed = true`) | ||
| console.log(`checking isPermissionValidator Module installed...`) | ||
| // check whether PermissionValidator module is install or not | ||
| const isPermissionValidatorModuleInstalled = await this.publicClient.readContract({ | ||
| address: this.client.account.address, | ||
| abi: isModuleInstalledAbi, | ||
| functionName: 'isModuleInstalled', | ||
| args: [ | ||
| BigInt(1), // ModuleType | ||
| PERMISSION_VALIDATOR_ADDRESS, // Module Address | ||
| '0x' // Additional Context | ||
| ] | ||
| }) | ||
| // if not then install Permissionvalidator module on Safe7579 Account. | ||
| if (!isPermissionValidatorModuleInstalled) { | ||
| console.log(`isPermissionValidatorModuleInstalled == false`) | ||
| console.log(`Should not have happen, need to debug initCode to check safe setUp process`) | ||
| throw new Error( | ||
| 'isPermissionValidatorModuleInstalled == false \n Should not have happen, need to debug initCode to check safe setUp process' | ||
| ) | ||
| // TODO: install the module , but for safe7579 PERMISSION_VALIDATOR module is | ||
| // part of initial validator module, so on safe setup phase it get installed. |
There was a problem hiding this comment.
Can we extract to its own private method?
There was a problem hiding this comment.
Same with the permissions code below
lukaisailovic
approved these changes
Jun 17, 2024
KannuSingh
deleted the
permissions-flow-with-safe7579UserOperationBuilder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.