Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wallet service's getCallsStatus rpc #755

Merged
merged 17 commits into from
Nov 5, 2024

Conversation

KannuSingh
Copy link
Collaborator

  • use wallet_getCallsStatus from wallet service in smart-sessions-demo instead of directly interacting with pimlico infra.
  • add support for wallet_getCallsStatus rpc on sample wallet wallet service.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-react-ethersv5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
appkit-react-wagmi-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
appkit-solana 🛑 Canceled (Inspect) Nov 5, 2024 2:44pm
decentralized-relay-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
decentralized-relay-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
malicious-dapp-verify-simulation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
react-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:44pm
react-wallet-v2 ✅ Ready (Inspect) Visit Preview Nov 5, 2024 2:44pm
smart-sessions-demo 🛑 Canceled (Inspect) Nov 5, 2024 2:44pm
vue-web-examples 🛑 Canceled (Inspect) Nov 5, 2024 2:44pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
react-auth-dapp ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
react-auth-wallet ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
react-dapp-v2-cosmos-provider ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
svelte-web3modal ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm
vue-dapp-auth ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 2:44pm

@KannuSingh KannuSingh marked this pull request as ready for review October 30, 2024 07:08
Added max retry attempt of 3 on api call failure, bc some rpc calls(wallet_getCallsStatus) seems very flaky.
throw error; // If max retries reached, throw the error
}
console.warn(`Attempt ${attempt} failed. Retrying...`); // Log the retry attempt
await new Promise((resolve) => setTimeout(resolve, 1000)); // Wait before retrying (optional delay)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have timeout duration in a const?

Copy link
Collaborator

@lukaisailovic lukaisailovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we implement this in the wallet service in the react-wallet? We don't really have to maintain that anymore since we have a prod one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants