chore: restore wasm #114
Open
chore: restore wasm #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris13524
commented
Jan 14, 2025
| // https://github.com/seanmonstar/reqwest/pull/1760 | ||
| #[cfg(not(target_arch = "wasm32"))] | ||
| let req = req.timeout(Duration::from_secs(5)); | ||
| req |
There was a problem hiding this comment.
This seems like the only hitch with building wasm; reqwest doesn't support specifying a timeout on requests.
There is a PR to implement this, but it hasn't been merged in 2 years for unknown reasons.
We can get away without this for now though, it's not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables support for building for wasm and fixes resulting build errors
Slack conversation