Skip to content

Commit

Permalink
Add rpc calls to unregister recordings from catalog (#8566)
Browse files Browse the repository at this point in the history
### What

This adds two simple `rpc` calls, `UnregisterRecording` and
`UnregisterAllRecordings`, to the storage node interface.
  • Loading branch information
grtlr authored Jan 8, 2025
1 parent 448642a commit ddaeb06
Show file tree
Hide file tree
Showing 2 changed files with 203 additions and 0 deletions.
16 changes: 16 additions & 0 deletions crates/store/re_protos/proto/rerun/v0/remote_store.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ service StorageNode {
// metadata API calls
rpc QueryCatalog(QueryCatalogRequest) returns (stream DataframePart) {}
rpc UpdateCatalog(UpdateCatalogRequest) returns (UpdateCatalogResponse) {}

// TODO(zehiko) support registering more than one recording at a time
rpc RegisterRecording(RegisterRecordingRequest) returns (DataframePart) {}

rpc UnregisterRecording(UnregisterRecordingRequest) returns (UnregisterRecordingResponse) {}
rpc UnregisterAllRecordings(UnregisterAllRecordingsRequest) returns (UnregisterAllRecordingsResponse) {}
}

// ---------------- Common response message ------------------
Expand Down Expand Up @@ -41,6 +45,18 @@ message RegisterRecordingRequest {
DataframePart metadata = 4;
}

// ---------------- Unregister from catalog ------------------

message UnregisterRecordingRequest {
// unique identifier of the recording
rerun.common.v0.RecordingId recording_id = 1;
}
message UnregisterRecordingResponse {}

message UnregisterAllRecordingsRequest {}
message UnregisterAllRecordingsResponse {}


// ---------------- UpdateCatalog -----------------

message UpdateCatalogRequest {
Expand Down
187 changes: 187 additions & 0 deletions crates/store/re_protos/src/v0/rerun.remote_store.v0.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ddaeb06

Please sign in to comment.