Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax lookup: Deprecated decorator #349

Merged
merged 6 commits into from
May 15, 2021
Merged

Syntax lookup: Deprecated decorator #349

merged 6 commits into from
May 15, 2021

Conversation

kevanstannard
Copy link
Contributor

Suggestion for #162

I'm not sure if we have any docs for this one yet so I haven't included any references.

PR should be editable, please feel free edit.

@ryyppy
Copy link
Member

ryyppy commented May 11, 2021

Same game here as in the warning attribute... there's I think @@deprecated for the module level as well if i am not mistaken... I guess we can treat module / scope level differently...?

@kevanstannard
Copy link
Contributor Author

I think @@deprecated for the module level as well if i am not mistaken

Great. It looks like it works as follows:

[1] Use @@deprecated at the file module level.
[2] Use @deprecated for everything else, including modules within files.

Working nicely in VSCode with both @@deprecated and @@deprecated("Some message") syntax.

I guess we can treat module / scope level differently...?

Putting them on different pages in the Syntax Lookup seems sensible to me. I feel that seeing both @deprecated and @@deprecated in the syntax list helps to clarify they two distinct syntaxes.

What do you think?

@ryyppy
Copy link
Member

ryyppy commented May 13, 2021

Sounds good! So let's make it clear how each decorator attaches to expressions / modules in separate widget items

@kevanstannard
Copy link
Contributor Author

Hi @ryyppy, PR updated, what do you think?

@ryyppy ryyppy merged commit f8e82b9 into rescript-lang:master May 15, 2021
@ryyppy
Copy link
Member

ryyppy commented May 15, 2021

awesome!

@kevanstannard
Copy link
Contributor Author

@ryyppy btw, thanks for your suggestions/updates, it's very helpful for me to better understand how some of the concepts should be expressed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants