Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Syntax lookup] Add doc for string literal syntax #352

Merged

Conversation

kellydanma
Copy link
Contributor

Proposal for #162

This is my first time opening a PR 👋 Edits are enabled, please send suggestions.

@kellydanma kellydanma changed the title WIP: [Syntax widget] Create syntax doc for string delimiter [Syntax widget] Create syntax doc for string delimiter May 9, 2021
@kellydanma kellydanma marked this pull request as ready for review May 9, 2021 04:32
@kellydanma kellydanma changed the title [Syntax widget] Create syntax doc for string delimiter [Syntax lookup] Add doc for string delimiter May 9, 2021
@kellydanma kellydanma mentioned this pull request May 9, 2021
89 tasks
Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! just a few details added as a comment

id: "string-delimiter"
keywords: ["string", "delimiter"]
name: "\"\""
summary: "This is the `string` delimiter."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
summary: "This is the `string` delimiter."
summary: "This is the `string` literal syntax."

@@ -0,0 +1,33 @@
---
id: "string-delimiter"
keywords: ["string", "delimiter"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keywords: ["string", "delimiter"]
keywords: ["string"]

category: "languageconstructs"
---

The `string` delimiter is composed of two **double** quotes. Single quotes are reserved for the `char` type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `string` delimiter is composed of two **double** quotes. Single quotes are reserved for the `char` type.
A `string` literal is composed of two **double** quotes. Single quotes are reserved for the `char` type.

@@ -0,0 +1,33 @@
---
id: "string-delimiter"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: "string-delimiter"
id: "string-literal"

@kellydanma kellydanma changed the title [Syntax lookup] Add doc for string delimiter [Syntax lookup] Add doc for string literal syntax May 10, 2021
@kellydanma
Copy link
Contributor Author

Thanks @ryyppy, updated.

@ryyppy ryyppy merged commit 1308887 into rescript-lang:master May 11, 2021
@ryyppy
Copy link
Member

ryyppy commented May 11, 2021

Looking great. Thanks!

@kellydanma kellydanma deleted the syntax_widget/string_delimiter branch May 11, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants