Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Lookup: Extension Points #444

Merged
merged 11 commits into from
Sep 9, 2021
Merged

Syntax Lookup: Extension Points #444

merged 11 commits into from
Sep 9, 2021

Conversation

kevanstannard
Copy link
Contributor

Suggestion for #162

First pass at adding Extension Point docs to Syntax Lookup.

Feel free to edit.

ryyppy
ryyppy reviewed Sep 9, 2021
View reviewed changes
misc_docs/syntax/extension_embed_raw_top_level.mdx Outdated
```

</CodeTab>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's also very useful to do imports with side-effects like this:
```res
%%raw(`import "main.css"`)
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I've included this change 👍

ryyppy
ryyppy reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@ryyppy ryyppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really sharp 👍

Made some comments, might need some file renaming, and some commit suggestion batching. All in all I like it.

@kevanstannard
Copy link
Contributor Author

kevanstannard commented Sep 9, 2021 •
edited
Loading

Hi @ryyppy, thanks for your suggestions, they look super clean. I believe I've applied all of them.

Edit: I didn't apply the link suggestion as they're currently not working for me. Let me know what your preference is here. I'd be happy to take a look at the routing code if you like.

@ryyppy
Copy link
Member

ryyppy commented Sep 9, 2021

Edit: I didn't apply the link suggestion as they're currently not working for me. Let me know what your preference is here. I'd be happy to take a look at the routing code if you like.

How does this not work? strange. Okay yeah then we need to check what's wrong and fix that first. If you wanna take a stab at this, feel free to do so!

ryyppy
ryyppy reviewed Sep 9, 2021
View reviewed changes
misc_docs/syntax/extension_raw_top_level.mdx Outdated
@@ -0,0 +1,57 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request: Can you rename this file to extension_raw_top_level_expression.mdx? Then we are ready to go!

@ryyppy ryyppy merged commit 09bb722 into rescript-lang:master Sep 9, 2021
@ryyppy
Copy link
Member

ryyppy commented Sep 9, 2021

Perfect, thanks!

@kevanstannard kevanstannard deleted the syntax-lookup-extension-points branch September 9, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryyppy ryyppy ryyppy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevanstannard @ryyppy