Automate playground compiler #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be merged, part two is independent. |
zth
reviewed
Jul 20, 2023
aspeddro
changed the title
|
rescript-compiler repo PR rescript-lang/rescript#6449 Now we need to pass the environment variable |
aspeddro
commented
Oct 25, 2023
aspeddro
commented
Oct 25, 2023
|
Ready for review |
|
@aspeddro I haven't really been in this part of the code yet. Who'd be good to review you think? |
ryyppy
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
LGTM. I added some nitpicks, but if you feel this is the way to go, we can also just merge.
I already added the relevant NEXT_REVALIDATE_SECRET_TOKEN secret to the Vercel settings and the rescript-compiler repo secrets.
So as soon as we merge this, everything should just work, I assume.
|
@ryyppy the deployment failed. I can't see the log either
|
|
had to approve the deployment |
cknitt
approved these changes
Oct 28, 2023
zth
pushed a commit
that referenced
this pull request
Nov 2, 2023
* first tests * automate playground versions * fix typo * refactor * refactor * refactor * format * remove log * remove json binding * add revalidate route * parse rc * order experimental versions * last adjusts * cleanup * move Semver to CompilerManagerHook module
fhammerschmidt
pushed a commit
that referenced
this pull request
Nov 14, 2023
* first tests * automate playground versions * fix typo * refactor * refactor * refactor * format * remove log * remove json binding * add revalidate route * parse rc * order experimental versions * last adjusts * cleanup * move Semver to CompilerManagerHook module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to split this PR into two parts because the second requires NextJS version 12. Waiting for #645 to finish the second part.Part 2 #565: